Horton

Re: logical replication syntax (was DROP SUBSCRIPTION, query cancellations and slot handling)

Peter Eisentraut <peter.eisentraut@2ndquadrant.com>

View thread View on postgr.es
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Petr Jelinek <petr.jelinek@2ndquadrant.com>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>, Michael Paquier <michael.paquier@gmail.com>, PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Date: 2017-05-08T20:55:36Z
Lists: pgsql-hackers 
On 5/5/17 13:01, Petr Jelinek wrote:
> What do you think of attached. I actually did add RESTRICT/CASCADE, in a
> way that if there is slot RESTRICT will refuse to drop subscription and
> CASCADE will try to drop it. Still all errors.
> 
> The new way to not drop slot is to set slot_name to NONE which is new
> value that I invented (inspiration from OWNED BY sequences) which
> basically disassociates the subscription from slot.
> 
> It's slightly less automatic this way but perhaps that's not a bad
> thing, at least nobody will drop slots by mistake while we still make
> sure that slots are not left over without anybody noticing.

I think this is OK.  Could you send a version of this patch based on
master please?

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Remove the NODROP SLOT option from DROP SUBSCRIPTION