Re: get rid of Pointer type, mostly

David Geier <geidav.pg@gmail.com>

From: David Geier <geidav.pg@gmail.com>
To: Robert Haas <robertmhaas@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter@eisentraut.org>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2025-12-08T10:25:28Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →
  1. Remove no longer needed casts from Pointer

  2. Remove no longer needed casts to Pointer

  3. Change Pointer to void *

  4. Don't rely on pointer arithmetic with Pointer type

  5. Use more appropriate DatumGet* function

  6. Remove useless casts to Pointer

Hi Peter,
> I went with your proposal of GinExtraPointer. See attached patch. It's
> based on the series of patches from Peter's initial mail. I've included
> the removal of the Pointer typedef in the same patch.

It seems to me that we reached agreement. Are you planning to still
apply these patches?

--
David Geier