Horton

Thread

Commits

  1. Minor code review for parse_phrase_operator().

  1. A mistake in a comment

    Victor Drobny <v.drobny@postgrespro.ru> — 2017-06-26T08:02:36Z

    Hello,

I believe that I have found a mistake in a comment to 
parse_phrase_operator function. The comment has the following line:
a <X> b (distance is no greater than X)
which is not. According to documentation and practical results, this 
line should me changed on something like:
a <X> b (distance is equal to X)

Patch in the attachments fixes the issue.

Thank you for attention!

Best,
Victor

  2. Re: A mistake in a comment

    Tom Lane <tgl@sss.pgh.pa.us> — 2017-06-26T13:54:04Z

    Victor Drobny <v.drobny@postgrespro.ru> writes:
> I believe that I have found a mistake in a comment to 
> parse_phrase_operator function. The comment has the following line:
> a <X> b (distance is no greater than X)
> which is not. According to documentation and practical results, this 
> line should me changed on something like:
> a <X> b (distance is equal to X)

Ah, this comment got missed when we changed the definition of <N>.

> Patch in the attachments fixes the issue.

Will apply, thanks.  Looks to me like there's an outright bug here
as well: if errno happened to already be ERANGE when we reach the
strtol() call, the code will incorrectly report an error.

			regards, tom lane