Horton

Thread

Commits

  1. Add tab completion for EXPLAIN (SETTINGS) in psql

  2. Fix lockmode initialization for custom relation options

  3. Stamp 12rc1.

  1. tab complete for explain SETTINGS

    Justin Pryzby <pryzby@telsasoft.com> — 2019-09-27T02:20:51Z

    Here's to hoping this is the worst omission in v12.

Justin

  2. Re: tab complete for explain SETTINGS

    Tatsuro Yamada <tatsuro.yamada.tf@nttcom.co.jp> — 2019-09-27T03:18:17Z

    On 2019/09/27 11:20, Justin Pryzby wrote:
> Here's to hoping this is the worst omission in v12.
> 
> Justin
> 

Hi Justin,

I share my test result of your patch.

I used two commits REL_12_RC1 and Head, and got a Hunk below:

#REL_12_RC1 (17822c0e4f5ab8093e78f665c9e44766ae648a44)
=============================
$ patch -p1 <v1-0001-tab-completion-for-explain-SETTINGS.patch
(Stripping trailing CRs from patch; use --binary to disable.)
patching file src/bin/psql/tab-complete.c
Hunk #1 succeeded at 2886 (offset -57 lines).
=============================

#Head (fbfa5664882c9b61428266e6fb0d48b0147c421a)
=============================
$ patch -p1 <v1-0001-tab-completion-for-explain-SETTINGS.patch
(Stripping trailing CRs from patch; use --binary to disable.)
patching file src/bin/psql/tab-complete.c
Hunk #1 succeeded at 2940 (offset -3 lines).
=============================


Anyway, I tested the patch and it looks fine. :)

#Test result of tab-completion on Head
=============================
# explain (
ANALYZE   BUFFERS   COSTS     FORMAT    SETTINGS  SUMMARY   TIMING    VERBOSE

# explain (s
settings  summary

# explain (settings ON ) select * from pg_class;
                          QUERY PLAN
-------------------------------------------------------------
  Seq Scan on pg_class  (cost=0.00..16.95 rows=395 width=265)
  Settings: geqo_threshold = '10'
(2 rows)
=============================


Thanks,
Tatsuro Yamada

  3. Re: tab complete for explain SETTINGS

    Michael Paquier <michael@paquier.xyz> — 2019-09-27T03:55:50Z

    On Fri, Sep 27, 2019 at 12:18:17PM +0900, Tatsuro Yamada wrote:
> Anyway, I tested the patch and it looks fine. :)

Thanks Justin and Yamada-san.  The order of the options in the list to
display and in the check did not match the order of the documentation,
which is the intention here, so fixed and committed this way.

(The list of options displayed would be alphabetically ordered for the
completion but it is good to keep the code consistent with the docs,
this makes easier future checks when adding new options).
--
Michael