Re: [17] CREATE SUBSCRIPTION ... SERVER

Jeff Davis <pgsql@j-davis.com>

From: Jeff Davis <pgsql@j-davis.com>

To: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>

Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, Joe Conway <mail@joeconway.com>, pgsql-hackers@postgresql.org

Date: 2024-01-13T01:17:26Z

Lists: pgsql-hackers

Attachments

v6-0001-Fix-postgresql_fdw_validator-to-use-full-libpq-op.patch (text/x-patch) patch v6-0001
v6-0002-Add-built-in-foreign-data-wrapper-pg_connection_f.patch (text/x-patch) patch v6-0002
v6-0003-CREATE-SUSBCRIPTION-.-SERVER.patch (text/x-patch) patch v6-0003

On Fri, 2024-01-05 at 16:11 +0530, Ashutosh Bapat wrote:
> I don't think we need to add a test for every FDW. E.g. adding a test
> in file_fdw would be pointless. But postgres_fdw is special. The test
> could further create a foreign table ftab_foo on subscriber
> referencing foo on publisher and then compare the data from foo and
> ftab_foo to make sure that the replication is happening. This will
> serve as a good starting point for replicated tables setup in a
> sharded cluster.
> 

Attached updated patch set with added TAP test for postgres_fdw, which
uses a postgres_fdw server as the source for subscription connection
information.

I think 0004 needs a bit more work, so I'm leaving it off for now, but
I'll bring it back in the next patch set.

Regards,
	Jeff Davis

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Document new catalog columns, missed in commit 8185bb5347.
- 90630ec42939 19 (unreleased) landed
Refactor to remove ForeignServerName().
- 11f8018ee678 19 (unreleased) landed
GetSubscription(): use per-object memory context.
- f16f5d608ca6 19 (unreleased) landed
Fix dependency on FDW's connection function.
- 4a0b46b6e1e4 19 (unreleased) landed
ALTER SUBSCRIPTION ... SERVER test.
- 1c5bf1185af0 19 (unreleased) landed
Fix pg_dump for CREATE FOREIGN DATA WRAPPER ... CONNECTION.
- b71bf3b84570 19 (unreleased) landed
Clean up postgres_fdw/t/010_subscription.pl.
- f4af7849b3db 19 (unreleased) landed
CREATE SUBSCRIPTION ... SERVER.
- 8185bb534763 19 (unreleased) landed
Allow upgrades to preserve the full subscription's state.
- 9a17be1e244a 17.0 cited