Re: meson: Non-feature feature options

Daniel Gustafsson <daniel@yesql.se>

From: Daniel Gustafsson <daniel@yesql.se>
To: Nazir Bilal Yavuz <byavuz81@gmail.com>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>, Andres Freund <andres@anarazel.de>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2023-03-09T14:15:49Z
Lists: pgsql-hackers
> On 9 Mar 2023, at 15:12, Nazir Bilal Yavuz <byavuz81@gmail.com> wrote:
> 
> Hi,
> 
> On Thu, 9 Mar 2023 at 16:54, Daniel Gustafsson <daniel@yesql.se> wrote:
>> 
>>> On 9 Mar 2023, at 14:45, Peter Eisentraut <peter.eisentraut@enterprisedb.com> wrote:
>> 
>>> How about we just hardcode "openssl" here instead?  We could build that array dynamically, of course, but maybe we leave that until we actually have a need?
>> 
>> At least for 16 keeping it hardcoded is an entirely safe bet so +1 for leaving
>> additional complexity for when needed.
> 
> We already have the 'ssl_library' variable. Can't we use that instead
> of hardcoding 'openssl'? e.g:
> 
> summary(
>  {
>    'ssl': ssl.found() ? [ssl, '(@0@)'.format(ssl_library)] : ssl,
>  },
>  section: 'External libraries',
>  list_sep: ', ',
> )
> 
> And it will output:
> ssl                    : YES 3.0.8, (openssl)
> 
> I don't think that using 'ssl_library' will increase the complexity.

That seems like a good idea.

--
Daniel Gustafsson




Commits

  1. meson: fix openssl detection issues in 6a30027

  2. meson: Make auto the default of the ssl option