Re: MSVC SSL test failure
Daniel Gustafsson <daniel@yesql.se>
From: Daniel Gustafsson <daniel@yesql.se>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Dunstan <andrew@dunslane.net>,
PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
Alexander Lakhin <exclusion@gmail.com>,
Lars Kanis <lars@greiz-reinsdorf.de>
Date: 2021-12-06T13:38:23Z
Lists: pgsql-hackers
> On 6 Dec 2021, at 07:02, Tom Lane <tgl@sss.pgh.pa.us> wrote: > > Andrew Dunstan <andrew@dunslane.net> writes: >> On 12/5/21 12:50, Tom Lane wrote: >>> This looks quite a bit like the sort of failure that commit >>> 6051857fc was meant to forestall. I wonder whether reverting >>> that commit changes the results? You might also try inserting >>> a shutdown() call, as we'd decided not to do [1]. > >> Commenting out the closesocket() worked. > > Man, that's annoying. Apparently OpenSSL is doing something to > screw up the shutdown sequence. According to [1], the graceful > shutdown sequence will happen by default, but changing SO_LINGER > or SO_DONTLINGER can get you into abortive shutdown anyway. > Maybe they change one of those settings (why?) AFAICT they don't touch either, and nothing really sticks out looking at setsockopt calls in either 1.1.1 or 3.0.0. -- Daniel Gustafsson https://vmware.com/
Commits
-
On Windows, also call shutdown() while closing the client socket.
- 878f38b80e91 10.20 landed
- 23bc57d564b2 11.15 landed
- a9e572c6d576 12.10 landed
- a8a983e8299a 13.6 landed
- ea5ecdadf6ea 14.2 landed
- ed52c3707bcf 15.0 landed
-
On Windows, close the client socket explicitly during backend shutdown.
- 6051857fc953 15.0 cited