Horton

Re: BUG #16171: Potential malformed JSON in explain output

Daniel Gustafsson <daniel@yesql.se>

View thread View on postgr.es
From: Daniel Gustafsson <daniel@yesql.se>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: depesz@depesz.com, Hamid Akhtar <hamid.akhtar@gmail.com>, pgsql-hackers@lists.postgresql.org
Date: 2020-02-03T12:55:19Z
Lists: pgsql-bugs, pgsql-hackers 
> On 2 Feb 2020, at 17:48, Tom Lane <tgl@sss.pgh.pa.us> wrote:

> Thoughts?

Keeping TEXT explain stable across minor versions is very appealing, but more
so from a policy standpoint than a technical one.  The real-world implication
is probably quite small, but that's a very unscientific guess (searching Github
didn't turn up anything but thats far from conclusive).  Having broken JSON is
however a clear negative, and so is having a different JSON format in back-
branches for something which has never worked in the first place.

I guess I'm leaning towards backpatching, but it's not entirely clear-cut.

cheers ./daniel

Commits

  1. Fix handling of "Subplans Removed" field in EXPLAIN output.

  2. Doc: Fix list of storage parameters available for ALTER TABLE