Horton

Re: Make some xlogreader messages more accurate

Peter Eisentraut <peter.eisentraut@enterprisedb.com>

View thread View on postgr.es
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Jeevan Ladhe <jeevanladhe.os@gmail.com>, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2023-03-02T08:19:52Z
Lists: pgsql-hackers 
On 28.02.23 11:19, Jeevan Ladhe wrote:
> +1 for the changes.
> 
>  >1. Why is "wanted >=%u" any better than "wanted at least %u"? IMO, the
>  >wording as opposed to >= symbol in the user-facing messages works
>  >better.
> 
> I think I agree with Bharath on this: "wanted at least %u" sounds better
> for user error than "wanted >=%u".

I committed this with "at least", as suggested, and also changed 
"wanted" to "expected", which matches the usual error message style better.

Commits

  1. Make some xlogreader messages more accurate