Horton

Re: pg_waldump and PREPARE

Andrei Lepikhov <a.lepikhov@postgrespro.ru>

View thread View on postgr.es
From: Andrey Lepikhov <a.lepikhov@postgrespro.ru>
To: Fujii Masao <masao.fujii@gmail.com>, Michael Paquier <michael@paquier.xyz>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>, Thomas Munro <thomas.munro@gmail.com>, Julien Rouhaud <rjuju123@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>, vignesh C <vignesh21@gmail.com>
Date: 2019-11-08T03:23:41Z
Lists: pgsql-hackers 

On 08/11/2019 05:53, Fujii Masao wrote:
> On Fri, Nov 8, 2019 at 9:41 AM Michael Paquier <michael@paquier.xyz> wrote:
>>
>> On Tue, Sep 03, 2019 at 10:00:08AM +0900, Fujii Masao wrote:
>>> Sorry for the long delay... Yes, I will update the patch if necessary.
>>
>> Fujii-san, are you planning to update this patch then?  I have
>> switched it as waiting on author.
> 
> No because there has been nothing to update in the latest patch for now
> unless I'm missing something. So I'm just waiting for some new review
> comments against the latest patch to come :)
> Can I switch the status back to "Needs review"?
> 
> Regards,
> 

One issue is that your patch provides small information. WAL errors 
Investigation often requires information on xid, subxacts, 
delete-on-abort/commit rels; rarely - invalidation messages etc.

-- 
Andrey Lepikhov
Postgres Professional
https://postgrespro.com
The Russian Postgres Company

Commits

  1. Fix comment in xact.h

  2. Make pg_waldump report more detail information about PREPARE TRANSACTION record.

  3. Store 2PC GID in commit/abort WAL recs for logical decoding