Re: Clean up MinGW def file generation
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Michael Paquier <michael@paquier.xyz>,
Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
pgsql-hackers@postgresql.org
Date: 2019-10-18T13:00:14Z
Lists: pgsql-hackers
Alvaro Herrera <alvherre@2ndquadrant.com> writes: > On 2019-Oct-17, Michael Paquier wrote: >> On Tue, Oct 15, 2019 at 09:00:23AM +0200, Peter Eisentraut wrote: >>> I think we can clean this up and just have the regular ddl.def built >>> normally at build time if required. >>> Does anyone know more about this? > Well, yes, but that code originates from much earlier. For example > 2a63c1602d9d (Tom Lane, Oct. 2004) is the one that created the libpq > ones. Yeah, the comment that Peter complained about is mine. I believe the desire to avoid depending on "sed" at build time was focused on our old support for building libpq with Borland C (and not much else). Since this makefile infrastructure is now only used for MinGW, I agree we ought to be able to quit shipping those files in tarballs. I think there could be some .gitignore cleanup done along with this. Notably, I see exclusions for /exports.list in several places, but no other references to that name --- isn't that an intermediate file that we used to generate while creating these files? regards, tom lane
Commits
-
Remove libpq-dist.rc
- 508e84d79910 13.0 landed
-
Clean up MinGW def file generation
- ea9e06ac66d3 13.0 landed
-
Refactor the code that creates the shared library export files to appear
- a1d5d8574751 8.4.0 cited
-
Make a separate win32 debug DLL along with the non-debug version:
- 53cd7cd8a916 8.0.0 cited