Re: BUG #16154: pg_ctl restart with a logfile fails sometimes (on Windows)
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alexander Law <exclusion@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>,
PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Date: 2019-12-07T16:54:54Z
Lists: pgsql-bugs
Alexander Law <exclusion@gmail.com> writes: > What is the reason for the previous shell still accessing logfile? > Is the reason that we don't close it before unlinking the pid file? > We can't close the logfile, as it is opened by CMD, not by the postgres > process. (Postmaster is started by the command "CMD.EXE /C postgres ... >> logfile".) So it is closed by the CMD shell after the postgres process > exits and the postgres can't control this (as a child process). Hmm ... so if we were talking about Unix, a reasonable solution would be to avoid having a separate shell process, either by telling the shell to "exec" the postmaster or by using fork/exec directly with no shell. A 99% solution would be to use "&" so that the shell doesn't wait around for the postmaster to die. Are any of those ideas tenable on Windows? regards, tom lane
Commits
-
In pg_ctl, work around ERROR_SHARING_VIOLATION on the postmaster log file.
- be9d4b928060 12.2 landed
- 0da33c762b85 13.0 landed