Horton

Re: auto-sizing wal_buffers

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Greg Smith <greg@2ndquadrant.com>, Fujii Masao <masao.fujii@gmail.com>, Magnus Hagander <magnus@hagander.net>, pgsql-hackers@postgresql.org
Date: 2011-01-23T01:33:54Z
Lists: pgsql-hackers 
I wrote:
> Robert Haas <robertmhaas@gmail.com> writes:
>> Barring screams of agony^W^W^Whelpful suggestions for how to code this
>> more neatly, I'll go ahead and commit this.

> The show_hook sucks, and is unnecessary, as is exposing the format
> function.  Just set the GUC variable to the correct value.

Um: that was probably too brief.  "Just set" means "use SetConfigOption".
As penance, I've committed the corrected patch.

			regards, tom lane