Horton

Re: BUG #15844: MIPS: remove .set mips2 in s_lock.h to fix r6 build

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: YunQiang Su <wzssyqa@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, pgsql-bugs@lists.postgresql.org
Date: 2019-06-22T23:21:40Z
Lists: pgsql-bugs 
YunQiang Su <wzssyqa@gmail.com> writes:
> Tom Lane <tgl@sss.pgh.pa.us> 于2019年6月23日周日 上午6:37写道：
>> So I now think your original proposal was about the best way to do this,
>> though I'd tweak it to make the test be "#if __mips_isa_rev < 2", as

> here we should use #if __mips < 2 instead of __mips_isa_rev .

OK, will do.

			regards, tom lane

Commits

  1. Fix spinlock assembly code for MIPS so it works on MIPS r6.