Re: moving extraUpdatedCols out of RangeTblEntry (into ModifyTable)

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Amit Langote <amitlangote09@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Alvaro Herrera <alvherre@alvh.no-ip.org>
Date: 2023-01-06T06:33:35Z
Lists: pgsql-hackers
Amit Langote <amitlangote09@gmail.com> writes:
> BTW, you wrote in the commit message:
>     (At present it seems that we don't enforce that for partitioning
>     either, which is likely wrong to some degree or other; but the case
>     clearly needs to be handled with traditional inheritance.)

> Maybe I'm missing something, but AFICS, neither
> traditional-inheritance child tables nor partitions allow a generated
> column with an expression that is not the same as the parent's
> expression for the same generated column:

Well, there's some large holes in that, as per my post at [1].
I'm on board with locking this down for partitioning, but we haven't
done so yet.

			regards, tom lane

[1] https://www.postgresql.org/message-id/2793383.1672944799%40sss.pgh.pa.us



Commits

  1. Fix calculation of which GENERATED columns need to be updated.

  2. Push lpp variable closer to usage in heapgetpage()