Re: MSVC SSL test failure
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-12-05T17:50:45Z
Lists: pgsql-hackers
Andrew Dunstan <andrew@dunslane.net> writes: > I am getting this test failure 001_ssltests.pl on my test MSVC system > when SSL tests are enabled: > not ok 110 - certificate authorization fails with revoked client cert with server-side CRL directory: matches > # Failed test 'certificate authorization fails with revoked client cert with server-side CRL directory: matches' > # at t/001_ssltests.pl line 618. > # 'psql: error: connection to server at "127.0.0.1", port 59491 failed: server closed the connection unexpectedly > # This probably means the server terminated abnormally > # before or while processing the request. > # server closed the connection unexpectedly > # This probably means the server terminated abnormally > # before or while processing the request. > # server closed the connection unexpectedly > # This probably means the server terminated abnormally > # before or while processing the request.' > # doesn't match '(?^:SSL error: sslv3 alert certificate revoked)' > There's nothing terribly suspicious in the server log, so I'm not quite > sure what's going on here. Hmm .. does enabling log_connections/log_disconnections produce any useful info? This looks quite a bit like the sort of failure that commit 6051857fc was meant to forestall. I wonder whether reverting that commit changes the results? You might also try inserting a shutdown() call, as we'd decided not to do [1]. regards, tom lane [1] https://www.postgresql.org/message-id/1283317.1638213407%40sss.pgh.pa.us
Commits
-
On Windows, also call shutdown() while closing the client socket.
- 878f38b80e91 10.20 landed
- 23bc57d564b2 11.15 landed
- a9e572c6d576 12.10 landed
- a8a983e8299a 13.6 landed
- ea5ecdadf6ea 14.2 landed
- ed52c3707bcf 15.0 landed
-
On Windows, close the client socket explicitly during backend shutdown.
- 6051857fc953 15.0 cited