Horton

Re: abi-compliance-check failure due to recent changes to pg_{clear,restore}_{attribute,relation}_stats()

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Bruce Momjian <bruce@momjian.us>
Cc: "David E. Wheeler" <david@justatheory.com>, Nathan Bossart <nathandbossart@gmail.com>, pgsql-hackers@postgresql.org, Andrew Dunstan <andrew@dunslane.net>, Mankirat Singh <mankiratsingh1315@gmail.com>
Date: 2025-10-29T21:37:36Z
Lists: pgsql-hackers 
Bruce Momjian <bruce@momjian.us> writes:
> On Fri, Oct 17, 2025 at 07:07:36PM -0400, Tom Lane wrote:
>> That seems overcomplicated: how does the buildfarm know
>> what's a maintenance branch?  I think the rule should be
>> just "run ABI checks if the control file exists, else not".

> I assume we would want ABI breakage checks on master between Beta 1 and
> the time we branch for the new major release in July.

In the past we've never really thought that ABI was more than mildly
solidified until around rc1.  On the whole I'd rather wait until after
the branch before starting to check ABI, simply because I don't care
for the idea of adding .abi-compliance-history in the master branch
only to remove it again later.  Having said that, it would be good
if we *could* choose to do that, so I still do not like having any
policy decisions about which branches to check hard-wired into the
buildfarm client.

			regards, tom lane

Commits

  1. Add commit 24f6c1bd4 to v17 .abi-compliance-history.

  2. Add .abi-compliance-history to back-branches.

  3. Add reminder to create .abi-compliance-history.

  4. Update .abi-compliance-history file.

  5. Add .abi-compliance-history to v18 branch.

  6. Fix thinko in commit 7d129ba54.

  7. Fix lookups in pg_{clear,restore}_{attribute,relation}_stats().

  8. Add defenses against unexpected changes in the NodeTag enum list.