Re: renumber_oids.pl needs some updates
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: pgsql-hackers@lists.postgresql.org,
John Naylor <john.naylor@enterprisedb.com>
Date: 2022-04-20T21:10:18Z
Lists: pgsql-hackers
Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes: > On 20.04.22 22:45, Tom Lane wrote: >> The attached proposed patch invents a variant macro >> DECLARE_TOAST_WITH_MACRO for the relatively small number of cases >> where we need such OID macros. > This makes sense. > A more elaborate (future) project would be to have genbki.pl generate > all of IsSharedRelation(), which is the only place these toast-table-OID > macros are used, AFAICT. Perhaps. We invent shared catalogs at a slow enough rate that I'm not sure the effort would ever pay for itself in person-hours, but maybe making such invention a trifle less error-prone is worth something. I'd still want to keep this form of DECLARE_TOAST, in case someone comes up with a different reason to want macro names for toast OIDs. regards, tom lane
Commits
-
Use DECLARE_TOAST_WITH_MACRO() to simplify toast-table declarations.
- 40eba064b24d 15.0 landed
-
Add primary keys and unique constraints to system catalogs
- dfb75e478cac 14.0 cited