Re: patch: move dumpUserConfig call in dumpRoles function of pg_dumpall.c

Robert Haas <robertmhaas@gmail.com> writes:
> I don't really
> understand why it's not OK to just have pg_dump issue RESET ROLE at
> appropriate points in the process; that seems like it would be
> sufficient and not particularly ugly.

Well, it was alleged that that would fix this problem:
http://archives.postgresql.org/pgsql-hackers/2010-12/msg00916.php
but if it does fix it, I think that's a bug in itself:
http://archives.postgresql.org/pgsql-hackers/2010-12/msg01031.php

But more to the point, I think the specific case of "ALTER DATABASE SET
ROLE" is just one element of a class of problems, namely that settings
attached to either databases or roles could create issues for restoring
a dump.  Issuing RESET ROLE would fix only that one single case.

			regards, tom lane