Horton

Re: Move wal_buffers_full to WalUsage (and report it in pgss/explain)

Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>

View thread View on postgr.es
From: Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>, pgsql-hackers@lists.postgresql.org
Date: 2025-02-11T12:30:09Z
Lists: pgsql-hackers 
Hi,

Thank you for your work!

1. Perhaps In EXPLAIN you forget to check that usage->wal_buffers_full > 0:

if ((usage->wal_records > 0) || (usage->wal_fpi > 0) || 
(usage->wal_bytes > 0))


2. I have a small suggestion for pg_stat_statements: would it make sense 
to move wal_buffers_full next to wal_records, wal_fpi and wal_bytes? 
This way, all WAL-related information would be grouped together.

--
Best regards,
Ilia Evdokimov,
Tantor Labs LLC.

Commits

  1. Add information about WAL buffers full to VACUUM/ANALYZE (VERBOSE)

  2. Add information about WAL buffers being full to EXPLAIN (WAL)

  3. pg_stat_statements: Add wal_buffers_full

  4. Move wal_buffers_full from PgStat_PendingWalStats to WalUsage

  5. pg_stat_statements: Add columns to track parallel worker activity