Horton

Re: parallel.c oblivion of worker-startup failures

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2017-09-18T16:30:44Z
Lists: pgsql-hackers 
Amit Kapila <amit.kapila16@gmail.com> writes:
> Attached patch fixes these problems.

Hmm, this patch adds a kill(notify_pid) after one call to
ForgetBackgroundWorker, but the postmaster has several more such calls.
Shouldn't they all notify the notify_pid?  Should we move that
functionality into ForgetBackgroundWorker itself, so we can't forget
it again?

			regards, tom lane

Commits

  1. Report an ERROR if a parallel worker fails to start properly.

  2. Report failure to start a background worker.