Horton

Re: Is tuplesort meant to support bounded datum sorts?

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Rowley <dgrowleyml@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>, Ronan Dunklau <ronan.dunklau@aiven.io>
Date: 2021-07-12T16:10:24Z
Lists: pgsql-hackers 
David Rowley <dgrowleyml@gmail.com> writes:
> It looks like this has likely never come up before because the only
> time we use tuplesort_set_bound() is in nodeSort.c and
> nodeIncrementalSort.c, none of those currently use datum sorts.
> However, I'm thinking this is still a bug that should be fixed
> separately from Ronan's main patch.

Yeah, I think you're right.  The comment seems a little confused
though.  Maybe there's no need for it at all --- there's equivalent
code in e.g. writetup_datum that has no comment.

			regards, tom lane

Commits

  1. Fix theoretical bug in tuplesort