Horton

Re: BUG #15964: vacuumdb.c:187:10: error: use of undeclared identifier 'FD_SETSIZE'

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Andres Freund <andres@anarazel.de>, Alvaro Herrera <alvherre@2ndquadrant.com>, Dilip Kumar <dilipbalaut@gmail.com>, jungleboogie0@gmail.com, pgsql-bugs@lists.postgresql.org
Date: 2019-08-23T14:58:14Z
Lists: pgsql-bugs 
Michael Paquier <michael@paquier.xyz> writes:
> The latest patch does that:
> +    pg_log_fatal("too many jobs for this platform's select() -- try %d"
> Do you have a better suggestion to offer, like a s#jobs#-j/--jobs#?

That seems over-punctuated, plus it burdens the reader with unnecessary
detail.  Most SQL folk would be confused by the reference to SELECT,
I bet.  (In fact, don't we have a style guideline against mentioning
particular syscalls?)

How about just "too many jobs for this platform -- try %d" ?

			regards, tom lane

Commits

  1. Fix error handling of vacuumdb when running out of fds

  2. Fix error handling of vacuumdb and reindexdb when running out of fds

  3. Fix compilation failure of vacuumdb and reindexdb with OpenBSD

  4. Improve Assert output

  5. Refactor parallelization processing code in src/bin/scripts/

  6. vacuumdb: enable parallel mode