Horton

Re: master plpython check fails on Solaris 10

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Marina Polyakova <m.polyakova@postgrespro.ru>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, pgsql-hackers@postgresql.org
Date: 2018-02-14T16:51:54Z
Lists: pgsql-hackers 
Marina Polyakova <m.polyakova@postgrespro.ru> writes:
> On 14-02-2018 17:54, Tom Lane wrote:
>> I think we need to fix the error callback code so that it
>> uses the "arg" field to find the relevant procedure, and that
>> that's a back-patchable fix, because nested plpython functions
>> would show this up as wrong in any case.  That would also let us
>> undo the not-terribly-safe practice of having code between the
>> PLy_push_execution_context call and the PG_TRY that is supposed
>> to ensure the context gets popped again.

> Thank you very much! I'll try to implement this.

I hsve a patch mostly done already.

			regards, tom lane

Commits

  1. Add an assertion that we don't pass NULL to snprintf("%s").

  2. Fix broken logic for reporting PL/Python function names in errcontext.

  3. Fix typo

  4. Transaction control in PL procedures

  5. Fix docs typo

  6. plpython security and error handling fixes, from