Re: Win32 timezone matching
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Magnus Hagander <magnus@hagander.net>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2010-04-06T22:48:52Z
Lists: pgsql-hackers
Magnus Hagander <magnus@hagander.net> writes: > On Wed, Apr 7, 2010 at 00:02, Tom Lane <tgl@sss.pgh.pa.us> wrote: >> Oh, another thought here: what is the effect of the combination of this >> with your other proposal to add more timezones to the list? > [ none ] Ah, right, I hadn't looked closely at the logic before. Still have two comments though: * There are other error conditions that cause "break"s in that loop. Should we change the others? * There is a comment at the head of win32_tzmap[] explaining where the data came from; you need to update that. regards, tom lane