Re: Out arguments name of "pg_identify_object_as_address" function in 9.5.14 and 11beta3
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Jean-Pierre Pelletier <jean.pierre.pelletier0@gmail.com>,
pgsql-hackers@postgresql.org
Date: 2018-09-05T15:49:36Z
Lists: pgsql-hackers
Alvaro Herrera <alvherre@2ndquadrant.com> writes: > On 2018-Sep-03, Tom Lane wrote: >> I do not think we can change the names of the output arguments; >> it'd break existing queries. However, renaming input arguments >> shouldn't affect anything. So I propose we make pg_get_object_address' >> input arguments be named type,object_names,object_args for >> consistency with the other function, and update the docs to match. > Hmm, I don't think it's possible to rename input args without breaking > working code either: Yeah, Andrew noted the same ... > That said, I haven't heard of anyone using these functions in code yet, > so if we change it in 11 or 12 nobody is going to complain. ... and that's pretty much my feeling. It seems really unlikely that anyone's using named-argument notation for pg_get_object_address, and even if they are, it wouldn't be very painful to change, or just not use the notation if they need cross-branch compatibility. I think it's more useful in the long run to make the names consistent. Will go take care of it. regards, tom lane
Commits
-
Make argument names of pg_get_object_address consistent, and fix docs.
- 337bf254ae81 11.0 landed
- ae5205c8a8ef 12.0 landed
- ccd9a4dbc880 9.5.15 landed
- 5b114b045a47 9.6.11 landed
- 0f3637ace36b 10.6 landed