Horton

Re: BUG #16104: Invalid DSA Memory Alloc Request in Parallel Hash

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>, Alvaro Herrera <alvherre@2ndquadrant.com>, Andres Freund <andres@anarazel.de>, James Coleman <jtc331@gmail.com>, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Date: 2019-12-21T05:10:31Z
Lists: pgsql-bugs 
Thomas Munro <thomas.munro@gmail.com> writes:
> I ran the 150MB 4096 batch "sevenb" self-join with the "rotate" patch,
> and it worked as expected.  I'm now planning to commit that version,
> unless there are objections or someone wants to argue for a different
> way to spell rotate() etc.

FWIW, I do want to argue for a different way to spell that.  It seems
like a mighty generic function name --- in particular, there's no
hint of the word width we're rotating in.  Maybe "rotate32" would be
good enough, though I'm tempted to propose "pg_rotate32" or "rotate_bit32"
or some other variation on that.

			regards, tom lane

Commits

  1. Rotate instead of shifting hash join batch number.