Horton

Re: BUG #17391: While using --with-ssl=openssl and PG_TEST_EXTRA='ssl' options, SSL tests fail on OpenBSD 7.0

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Daniel Gustafsson <daniel@yesql.se>, Thomas Munro <thomas.munro@gmail.com>, byavuz81@gmail.com, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>, Heikki Linnakangas <heikki.linnakangas@iki.fi>, Michael Paquier <michael@paquier.xyz>
Date: 2022-02-15T01:22:34Z
Lists: pgsql-bugs 
Andres Freund <andres@anarazel.de> writes:
> Is the generation of the duplicated error message reliable in case of a
> pg_terminate_backend()? Kinda looks like it should be?

Yeah, I think it is.  libpq wouldn't notice EOF until after it
returns the backend's FATAL message.

> I guess I'll push the fix without a test for now...

Might as well push it with.  If that behavior isn't stable,
it'd be nice to know.

			regards, tom lane

Commits

  1. Move libpq's write_failed mechanism down to pqsecure_raw_write().

  2. Fix thinko in PQisBusy().

  3. Set SNI ClientHello extension to localhost in tests

  4. Improve worst-case performance of text_position_get_match_pos()