Horton

Re: xlog location arithmetic

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Fujii Masao <masao.fujii@gmail.com>, Magnus Hagander <magnus@hagander.net>, Euler Taveira de Oliveira <euler@timbira.com>, Pgsql Hackers <pgsql-hackers@postgresql.org>
Date: 2012-03-09T15:37:42Z
Lists: pgsql-hackers 
Robert Haas <robertmhaas@gmail.com> writes:
> On Fri, Mar 9, 2012 at 9:55 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Actually ... now that I look at it, isn't it completely bogus to be
>> using numeric for the result of pg_xlog_location_diff?

> rhaas=# select pg_xlog_location_diff('ffffffff/0', '0/0')::int8;
> ERROR:  bigint out of range

Oh ... I see my mistake.  I was looking at this:

	/*
	 * result = XLogFileSize * (xlogid1 - xlogid2) + xrecoff1 - xrecoff2
	 */

and confusing XLogFileSize with XLogSegSize.  Not the best choice of
names.

			regards, tom lane