Re: libpq changes for synchronous replication
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Fujii Masao <masao.fujii@gmail.com>, Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2010-11-19T15:25:13Z
Lists: pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes: > On Thu, Nov 18, 2010 at 7:43 AM, Fujii Masao <masao.fujii@gmail.com> wrote: >> The patch is touching protocol.sgml as follows. Isn't this enough? > How about some updates to the "Message Flow" section, especially the > section on "COPY Operations"? Yeah. You're adding a new fundamental state to the protocol; it's not enough to bury that in the description of a message format. I don't think a whole lot of new verbiage is needed, but the COPY section needs to point out that this is a different state that allows both send and receive, and explain what the conditions are for getting into and out of that state. regards, tom lane