Horton

Re: Bug fix for glibc broke freebsd build in REL_11_STABLE

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Andrew Gierth <andrew@tao11.riddles.org.uk>, Victor Wagner <vitus@wagner.pp.ru>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2018-12-01T18:30:10Z
Lists: pgsql-hackers 
I wrote:
> Looking at the buildfarm, our only extant member that is on x86, and
> is not using clang, and doesn't have -fexcess-precision=standard, is
> dromedary which is using Apple's old toolchain.  So the fact that it
> isn't showing the problem isn't very good evidence about how widespread
> this issue might be with older gcc versions.

... and, in fact, a bit of investigation says that that compiler has
-msse2 on by default.  So actually we have *no* buildfarm coverage
of x87 math.

I tried forcing the issue with -mfpmath=387, but failed to reproduce
the reported failure.  Still, seeing that it's a considerably different
version of gcc, that's not so surprising.

			regards, tom lane

Commits

  1. Error out for clang on x86-32 without SSE2 support, no -fexcess-precision.

  2. Fix 8a934d677 for libc++ and make more include order resistant.