Horton

Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: Proposal for Allow postgresql.conf values to be changed via SQL [review])

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Josh Berkus <josh@agliodbs.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>, Greg Smith <greg@2ndquadrant.com>, Amit kapila <amit.kapila@huawei.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, "'Fujii Masao'" <masao.fujii@gmail.com>, "'Robert Haas'" <robertmhaas@gmail.com>
Date: 2013-07-22T23:56:19Z
Lists: pgsql-hackers 
Josh Berkus <josh@agliodbs.com> writes:
> Christophe just discovered something with include files which is going
> to cause issues with ALTER SYSTEM SET.

> So, take as a hypothetical that you use the default postgresql.conf
> file, which sets shared_buffers = 32MB.

> Instead of editing this file, you do ALTER SYSTEM SET shared_buffers =
> '1GB', which updates config/postgresql.auto.conf.

> Then you restart PostgreSQL.

> Everything is hunky-dory, until a later occasion where you *reload*
> postgresql.

Everything was already *not* hunky-dory as soon as you did that, since
a SIGHUP would have had the same problem.

I'd be inclined to think that ALTER SYSTEM SET should not be allowed to
modify any PGC_POSTMASTER parameters.

			regards, tom lane