Re: BUG #16080: pg_ctl is failed if a fake cmd.exe exist in the current directory.
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>
Cc: cilizili@protonmail.com, pgsql-bugs@lists.postgresql.org
Date: 2019-10-28T18:16:21Z
Lists: pgsql-bugs
=?UTF-8?Q?Juan_Jos=C3=A9_Santamar=C3=ADa_Flecha?= <juanjo.santamaria@gmail.com> writes: > On Sun, Oct 27, 2019 at 4:42 PM Tom Lane <tgl@sss.pgh.pa.us> wrote: >> I poked around a bit for other references to cmd.exe. It looks >> like psql's do_shell() is handling this correctly already, but should >> we not also fix spawn_process() in src/test/regress/pg_regress.c ? > Agreed, so please find attached an updated patch. Looks OK now, so pushed. (I don't have the ability to test this locally, but the buildfarm will soon tell us if it's wrong.) regards, tom lane
Commits
-
On Windows, use COMSPEC to find the location of cmd.exe.
- f88544904e4b 13.0 landed