Re: Buffer usage in EXPLAIN and pg_stat_statements (review)

Euler Taveira de Oliveira <euler@timbira.com> writes:
> Itagaki Takahiro escreveu:
>> Thanks. Except choice of words, can I think the basic architecture of
>> the patch is ok? The codes to handle global variables like ReadBufferCount
>> and GlobalReadBufferCount could be rewrite in cleaner way if we could
>> drop supports of log_{parser|planner|executor|statement}_stats.
>> 
> Yes, it is. I'm afraid someone is relying on that piece of code.

If we have a better substitute, I think there'd be nothing wrong with
removing those features.  They were never anything but pretty crufty
anyway, and they are *not* a compatibility issue because applications
have no direct way to access those stats.  However, you'd have to be
sure that the substitute covers all the use-cases for the old stats
... which strikes me as a lot more territory than this patch has
proposed to cover.

			regards, tom lane