Horton

Re: meson: Add support for building with precompiled headers

Peter Eisentraut <peter.eisentraut@enterprisedb.com>

View thread View on postgr.es
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Andres Freund <andres@anarazel.de>, pgsql-hackers@postgresql.org, Thomas Munro <thomas.munro@gmail.com>, Justin Pryzby <pryzby@telsasoft.com>, Michael Paquier <michael.paquier@gmail.com>
Date: 2022-10-06T07:06:42Z
Lists: pgsql-hackers 
On 05.10.22 21:08, Andres Freund wrote:
> This is a patch split off from the initial meson thread [1] as it's
> functionally largely independent (as suggested in [2]).
> 
> Using precompiled headers substantially speeds up building for windows, due to
> the vast amount of headers included via windows.h. A cross build from
> linux targetting mingw goes from

These patches look ok to me.  I can't really comment on the Windows 
details, but it sounds all reasonable.

Small issue:

+override CFLAGS += -DFD_SETSIZE=1024

(and similar)

should be CPPFLAGS.

Commits

  1. windows: Adjust FD_SETSIZE via commandline define