Horton

Re: [RFC] building postgres with meson - v13

Peter Eisentraut <peter.eisentraut@enterprisedb.com>

View thread View on postgr.es
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: samay sharma <smilingsamay@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, Tom Lane <tgl@sss.pgh.pa.us>, Nathan Bossart <nathandbossart@gmail.com>, Andrew Dunstan <andrew@dunslane.net>, Thomas Munro <thomas.munro@gmail.com>, Justin Pryzby <pryzby@telsasoft.com>, Nazir Bilal Yavuz <byavuz81@gmail.com>, pgsql-hackers@postgresql.org
Date: 2022-10-05T06:40:59Z
Lists: pgsql-hackers 
On 03.10.22 09:39, samay sharma wrote:
>     9f5be26c1215 meson: Add docs for building with meson
> 
>     I do like the overall layout of this.
> 
>     The "Supported Platforms" section should be moved back to near the end
>     of the chapter.  I don't see a reason to move it forward, at least
>     none that is related to the meson issue.
> 
> 
> Agreed that it's unrelated to meson. However, I think it's better to 
> move it in the front as it's generally useful to know if your platform 
> is supported before you start performing the installation steps and get 
> stuck somewhere.

The way it is currently organized is that 17.2 says

"In general, a modern Unix-compatible platform should be able to run 
PostgreSQL. The platforms that had received specific testing at the time 
of release are described in Section 17.6 below."

So basically, it says, don't worry about it, your platform is probably 
supported, but check below if you are interested in the details.

I don't see a reason to turn this around.

> 
> Do you think I should submit that as a separate commit in the same 
> patch-set or just move it out to a completely different patch submission?
> 
> 
>     The changes to the "Getting the Source" section are also not
>     appropriate for this patch.
> 
> 
> Given that many developers are now using Git for downloading the source 
> code, I think it makes sense to be in the Getting the source section. 
> Also, meson today doesn't cleanly build via the tarballs. Hence, I added 
> it to the section (and patchset).

Section 17.3 already contains a link to section I.1 about using Git.

> Do you think I should move this to a different patch?

If you wanted to pursue these changes, then yes, but I think they are 
not clear improvements, as mentioned above.

I suggest focusing on getting the actual meson documentation finished 
and then considering polishing the overall flow if desired.

Commits

  1. meson: Add 'running' test setup, as a replacement for installcheck

  2. meson: Add support for building with precompiled headers

  3. windows: Adjust FD_SETSIZE via commandline define

  4. meson: docs: Add xml{lint,proc} wrapper to collect dependencies

  5. meson: ecpg: Split definition of static and shared libraries

  6. windows: Set UMDF_USING_NTSTATUS globally, include ntstatus.h

  7. ci: Add hint about downloadable logs to README

  8. meson: Set up absolute rpaths to libdir

  9. meson: Include CFLAGS/c_args in summary and pg_config output

  10. windows: remove date from version number in win32ver.rc

  11. meson: Add initial version of meson based build system

  12. ci: windows: set error mode to not include SEM_NOGPFAULTERRORBOX

  13. Refactor PG_TEST_EXTRA logic in autoconf build

  14. Split TESTDIR into TESTLOGDIR and TESTDATADIR

  15. Don't hardcode tmp_check/ as test directory for tap tests

  16. Extend gendef.pl in preparation for meson

  17. Include c.h instead of postgres.h in src/port/*p{read,write}*.c

  18. Remove DLLTOOL, DLLWRAP from configure / Makefile.global.in

  19. Run xmllint validation only once

  20. Bump minimum Perl version to 5.14

  21. Move gramparse.h to src/backend/parser

  22. Run perltidy over Catalog.pm

  23. Parse catalog .dat files as a whole when compiling the backend

  24. Build all Flex files standalone

  25. Move private declarations shared between guc.c and guc-file.l to new header

  26. Preparatory refactoring for compiling guc-file.c standalone

  27. Move darwin sysroot determination into separate file

  28. Fix MSVC warning in compat_informix/rnull.pgc

  29. solaris: Use versioning scripts instead of -Bsymbolic

  30. Change shared library installation naming on macOS

  31. regress: allow to specify directory containing expected files, for ecpg

  32. Don't add HAVE_LDAP_H HAVE_WINLDAP_H to pg_config.h

  33. Refactor dtrace postprocessing make rules

  34. Add output directory option to gen_node_support.pl

  35. Add output directory argument to generate-unicode_norm_table.pl

  36. Add output file argument to generate-errcodes.pl

  37. Add output path arg in generate-lwlocknames.pl

  38. Move snowball_create.sql creation into perl file

  39. ecpg: Output dir, source dir, stamp file argument for preproc/*.pl

  40. psql: Output dir and dependency generation for sql_help

  41. Deal with paths containing \ and spaces in basebackup_to_shell tests

  42. Remove LLVM_CONFIG from Makefile.global.in

  43. Make update-unicode target work in vpath builds

  44. Refactor DLSUFFIX handling

  45. ldap tests: Add paths for openbsd.

  46. ldap tests: Don't run on unsupported operating systems.

  47. Remove check for accept() argument types

  48. Move our p{read,write}v replacements into their own files.

  49. Adjust yywrap macro for non-reentrant scanners for MSVC.

  50. Remove any -arch switches given in ExtUtils::Embed's ldopts from our

  51. Change PL/Perl and Pg interface build to use configured compiler and

  52. Apparently, on some systems, ExtUtils::Embed and MakeMaker are slightly