Re: Online enabling of checksums

x4mmm@yandex-team.ru

From: Andrey Borodin <x4mmm@yandex-team.ru>
To: Magnus Hagander <magnus@hagander.net>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>, Daniel Gustafsson <daniel@yesql.se>, Michael Banck <michael.banck@credativ.de>
Date: 2018-02-27T16:51:29Z
Lists: pgsql-hackers
Hi, Magus!

> 25 февр. 2018 г., в 21:17, Magnus Hagander <magnus@hagander.net> написал(а):
> 
> PFA an updated patch that adds this, and also fixes the problem in pg_verify_checksums spotted by Michael Banck. 

I had to ALLOW_CONNECTIONS to template0 to make it work
postgres=# 2018-02-27 21:29:05.993 +05 [57259] ERROR:  Database template0 does not allow connections.
Is it a problem with my installation or some regression in the patch?

2018-02-27 21:40:47.132 +05 [57402] HINT:  either disable or enable checksums by calling the pg_data_checksums_enable()/disable() functions
Function names are wrong in this hint: pg_enable_data_checksums()

The code is nice and clear. One minor spot in the comment
>This option can only _be_ enabled when data checksums are enabled.

Is there any way we could provide this functionality for previous versions (9.6,10)? Like implement utility for offline checksum enabling, without WAL-logging, surely.


Thanks for the patch!

Best regards, Andrey Borodin.

Commits

  1. Online enabling and disabling of data checksums

  2. Deactive flapping checksum isolation tests.

  3. Add support for coordinating record typmods among parallel workers.