Horton

Re: Potential issue in ecpg-informix decimal converting functions

Daniel Gustafsson <daniel@yesql.se>

View thread View on postgr.es
From: Daniel Gustafsson <daniel@yesql.se>
To: Michael Paquier <michael@paquier.xyz>
Cc: a.imamov@postgrespro.ru, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2024-03-06T15:03:59Z
Lists: pgsql-hackers

Attachments

> On 27 Feb 2024, at 06:08, Michael Paquier <michael@paquier.xyz> wrote:
> 
> On Mon, Feb 26, 2024 at 12:28:51AM +0100, Daniel Gustafsson wrote:
>> Yeah, I think this is for HEAD only, especially given the lack of complaints
>> against backbranches.
> 
> Daniel, are you planning to look at that?  I haven't done any detailed
> lookup, but would be happy to do so it that helps.

I had a look at this today and opted for trimming back the patch a bit.
Reading the informix docs the functions we are mimicking for compatibility here
does not have an underflow returnvalue, so adding one doesn't seem right (or
helpful).  The attached fixes the return of overflow and leaves it at that,
which makes it possible to backpatch since it's fixing the code to match the
documented behavior.

--
Daniel Gustafsson

Commits

  1. doc: Document error handling in PGTYPESnumeric_to_long

  2. ecpg: Fix return code for overflow in numeric conversion