Re: Re: Proposal for Allow postgresql.conf values to be changed via SQL [review]
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Boszormenyi Zoltan <zb@cybertec.at>
Cc: Amit kapila <amit.kapila@huawei.com>, "'Robert Haas'" <robertmhaas@gmail.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2013-01-18T20:32:15Z
Lists: pgsql-hackers
Boszormenyi Zoltan <zb@cybertec.at> writes: > 2013-01-18 11:05 keltezssel, Amit kapila rta: >> On using mktemp, linux compilation gives below warning >> warning: the use of `mktemp' is dangerous, better use `mkstemp' >> >> So I planned to use mkstemp. > Good. On my HPUX box, the man page disapproves of both, calling them obsolete (and this man page is old enough to vote, I believe...) Everywhere else that we need to do something like this, we just use our own PID to disambiguate, ie sprintf(tempfilename, "/path/to/file.%d", (int) getpid()); There is no need to deviate from that pattern or introduce portability issues, since we can reasonably assume that no non-Postgres programs are creating files in this directory. regards, tom lane