Horton

Re: postgres_fdw: using TABLESAMPLE to collect remote sample

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Tomas Vondra <tomas.vondra@enterprisedb.com>
Cc: James Finnerty <jfinnert@amazon.com>, pgsql-hackers@lists.postgresql.org
Date: 2023-01-05T21:56:55Z
Lists: pgsql-hackers 
Tomas Vondra <tomas.vondra@enterprisedb.com> writes:
> There are no callers outside postgresAcquireSampleRowsFunc, so what
> about renaming them like this?

>   deparseAnalyzeTuplesSql
>     -> deparseAnalyzeInfoSql

>   postgresCountTuplesForForeignTable
>     -> postgresGetAnalyzeInfoForForeignTable

WFM.

			regards, tom lane

Commits

  1. Check relkind before using TABLESAMPLE in postgres_fdw

  2. Fix stale comment about sample_frac adjustment