Horton

Re: Add "-Wimplicit-fallthrough" to default flags (was Re: pgsql: Support FETCH FIRST WITH TIES)

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Julien Rouhaud <rjuju123@gmail.com>, pgsql-hackers@lists.postgresql.org
Date: 2020-05-11T04:47:58Z
Lists: pgsql-hackers 
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> On 2020-May-06, Alvaro Herrera wrote:
>> This doesn't allow whitespace between "fall" and "through", which means
>> we generate 217 such warnings currently.  Or we can just use
>> -Wimplicit-fallthrough=3, which does allow whitespace (among other
>> detritus).

> If we're OK with patching all those places, I volunteer to do so.  Any
> objections?  Or I can keep it at level 3, which can be done with minimal
> patching.

If we're gonna do it at all, I think we should go for the level 4
warnings.  Level 3's idea of a fallthrough comment is too liberal
for my tastes...

			regards, tom lane

Commits

  1. Dial back -Wimplicit-fallthrough to level 3

  2. Add -Wimplicit-fallthrough to CFLAGS and CXXFLAGS

  3. Suppress -Wimplicit-fallthrough warning in new LIMIT WITH TIES code.

  4. Support FETCH FIRST WITH TIES