Horton

Re: [Bug Fix] ECPG: could not use set xxx to default statement

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: "Higuchi, Daisuke" <higuchi.daisuke@jp.fujitsu.com>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2019-02-19T04:27:15Z
Lists: pgsql-hackers 
"Higuchi, Daisuke" <higuchi.daisuke@jp.fujitsu.com> writes:
> [ missing semicolon in gram.y breaks ecpg parsing of same construct ]

That's pretty nasty.  The fix in gram.y is certainly needed, but I'm
unexcited by the regression test additions you propose.  What I really
want to know is why a syntax error in gram.y wasn't detected by any
of the tools we use, and whether we can do something about that.
Otherwise the next bug of the same kind may go just as undetected;
in fact, I've got little confidence there aren't other such omissions
already :-(

			regards, tom lane

Commits

  1. Fix ecpg bugs caused by missing semicolons in the backend grammar.