Horton
Menu

Re: Attribute of type record has wrong type error with MERGE ... WHEN NOT MATCHED BY SOURCE THEN DELETE

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Dean Rasheed <dean.a.rasheed@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, Tender Wang <tndrwang@gmail.com>, Duncan Sands <duncan.sands@deepbluecap.com>, pgsql-bugs@lists.postgresql.org
Date: 2025-03-13T16:15:33Z
Lists: pgsql-bugs 
Dean Rasheed <dean.a.rasheed@gmail.com> writes:
> On Thu, 13 Mar 2025 at 01:39, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> After some thought, I'm inclined to suggest that we just remove
>> the post-rewrite check in the affected branches.

> I don't really have any better ideas. I guess that if we wanted to
> keep this check in back branches, we could copy across the subquery
> RTE relids onto the new query, like we do for queryIds. But it would
> be somewhat messy, because we'd have to do something like walk each
> query pulling a list of its RTE_SUBQUERY RTEs, and then walk both
> lists, copying relids over. So maybe not worth the effort.

Yeah, I don't think it's worth it either -- testing something that's
not actually the behavior of the code-under-test seems pointless.

I've not thought of any better way, so pushed that one to get the
buildfarm back to green.  There's always "git revert" if somebody
has a better idea.

			regards, tom lane

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Repair commits 317aba70e et al for -DWRITE_READ_PARSE_PLAN_TREES.

  2. Build whole-row Vars the same way during parsing and planning.

  3. Preserve RangeTblEntry.relid when expanding a view RTE.

  4. Fix incorrect non-strict join recheck in MERGE WHEN NOT MATCHED BY SOURCE.