Horton

Re: some unused parameters cleanup

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2020-08-26T13:32:34Z
Lists: pgsql-hackers 
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> On 2020-08-25 18:59, Tom Lane wrote:
>> For some of these, there's an argument for keeping the unused parameter
>> for consistency with sibling functions that do use it.  Not sure how
>> important that is, though.

> I had meant to exclude cases like this from this patch set.  If you see 
> a case like this in *this* patch set, please point it out.

I'd been thinking specifically of the changes in pg_backup_archiver.c.
But now that I look around a bit further, there's already very little
consistency in that file about whether to pass the ArchiveHandle* pointer
everywhere.  So no further objection here.

			regards, tom lane

Commits

  1. Remove unused parameters

  2. Remove unused parameter

  3. Keep pg_stat_statements' query texts in a file, not in shared memory.