Horton
Menu

Re: pg_ctl restart bug

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter_e@gmx.net>
Cc: jmitchell@greatbridge.com, pgsql-bugs@postgresql.org
Date: 2001-04-20T20:25:09Z
Lists: pgsql-bugs 
pg_ctl restart works fine with this patch, but I'm not sure whether it
breaks useful cases for the other paths:

***************
*** 323,335 ****
  	    shift
              po_path=$1
              shift
! 	    POSTOPTS=$@
  	fi
      else # -o given
          POSTOPTS="-D $PGDATA $POSTOPTS"
      fi
  
!     eval '$po_path' '$POSTOPTS' $logopt '&'
  
      # if had an old lockfile, check to see if we were able to start
      if [ -n "$oldpid" ];then
--- 323,335 ----
  	    shift
              po_path=$1
              shift
! 	    POSTOPTS="$@"
  	fi
      else # -o given
          POSTOPTS="-D $PGDATA $POSTOPTS"
      fi
  
!     eval '$po_path' $POSTOPTS $logopt '&'
  
      # if had an old lockfile, check to see if we were able to start
      if [ -n "$oldpid" ];then



			regards, tom lane