Horton

Re: Add support for logging the current role

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Andrew Dunstan <andrew@dunslane.net>, Stephen Frost <sfrost@snowman.net>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2011-01-15T16:08:48Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Add support for an application_name parameter, which is displayed in

  2. Make CSV column ordering a bit more logical.

  3. Extend the format of CSV logs to include the additional information supplied

  4. Add virtual transaction IDs to CSVLOG output, so that messages coming from

  5. Provide for logfiles in machine readable CSV format. In consequence, rename

Robert Haas <robertmhaas@gmail.com> writes:
> On Fri, Jan 14, 2011 at 9:24 PM, Andrew Dunstan <andrew@dunslane.net> wrote:
>> What's your suggestion, then?

> If there's a practical way to add the requested escape, add it to the
> text format and leave reengineering the CSV format for another day.
> Yeah, I know that's not the most beautiful solution in the world, but
> we're doing engineering here, not theology.

Well, the original patch was exactly that.  But I don't agree with that
approach; I think allowing the capabilities of text and CSV logs to
diverge significantly would be a mistake.  If a piece of information is
valuable enough to need a way to include it in textual log entries,
then you need a way to include it in CSV log entries too.  If it's not
valuable enough to do the work to support it in CSV, then we can live
without it.

			regards, tom lane