Horton

Re: fairywren hung in pg_basebackup tests

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, Thomas Munro <thomas.munro@gmail.com>, Noah Misch <noah@leadboat.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-07-27T14:58:44Z
Lists: pgsql-hackers 
Andrew Dunstan <andrew@dunslane.net> writes:
> The alternative I thought of would be to switch msys to using our
> dirent.c. Probably not too hard, but certainly more work than reverting.

If you ask me, the shortest-path general-purpose fix is to insert

#if MSYS
	if (pgwin32_is_junction(path))
	    return PGFILETYPE_DIR;
#endif

at the start of get_dirent_type.  (I'm not sure how to spell the
#if test.)  We could look at using dirent.c later, but I think
right now it's important to un-break the buildfarm ASAP.

			regards, tom lane

Commits

  1. Fix get_dirent_type() for symlinks on MinGW/MSYS.