Horton

Re: Errands around AllocateDir()

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Michael Paquier <michael.paquier@gmail.com>, PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Date: 2017-12-04T19:00:13Z
Lists: pgsql-hackers 
Robert Haas <robertmhaas@gmail.com> writes:
> On Mon, Dec 4, 2017 at 12:05 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> The only part of this that seems likely to be controversial is the
>> decision to get rid of special-case error messages, eg replace
>> "could not open tablespace directory \"%s\": %m"
>> with the more generic
>> "could not open directory \"%s\": %m"
>> As I said in the previous thread, I don't see anything much wrong
>> with that; but if anyone doesn't like it, speak now.

> I find that change an improvement, but not something to back-patch.

Yeah, agreed.  The only thing I'm concerned about back-patching is
the places where a wrong errno might be reported.

			regards, tom lane

Commits

  1. Clean up assorted messiness around AllocateDir() usage.