Horton

Re: pg_dump --binary-upgrade vs. ALTER TYPE ... DROP ATTRIBUTE

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Noah Misch <noah@leadboat.com>, Peter Eisentraut <peter_e@gmx.net>, pgsql-hackers@postgresql.org
Date: 2011-04-21T03:37:04Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix pg_dump to handle collations applied to columns of composite types.

Robert Haas <robertmhaas@gmail.com> writes:
> On Wed, Apr 20, 2011 at 10:51 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> How about "ALTER TABLE tabname [NOT] OF TYPE typename"? It's at least a
>> smidgeon less ambiguous.

> I thought of that, but I hate to make CREATE TABLE and ALTER TABLE
> almost-but-not-quite symmetrical.

Oh, good point.

> But one might well wonder why we didn't decide on:
> CREATE TABLE n OF TYPE t;
> ...rather than the actual syntax:
> CREATE TABLE n OF t;
> ...which has brevity to recommend it, but likewise isn't terribly clear.

> I presume someone will now refer to a standard of some kind....

SQL:2008 11.3 <table definition>, the bits around <typed table clause>
to be specific.

The SQL committee's taste in syntax is, uh, not mine.  They are
amazingly long-winded in places and then they go and do something
like this ...

			regards, tom lane