Re: [HACKERS] [PATCH] relocation truncated to fit: citus build failure on s390x
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Christoph Berg <myon@debian.org>
Cc: Andres Freund <andres@anarazel.de>, Jason Petersen <jason@citusdata.com>,
pgsql-pkg-debian@postgresql.org,
PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2017-05-31T13:55:31Z
Lists: pgsql-hackers
Christoph Berg <myon@debian.org> writes: > Re: Tom Lane 2017-05-30 <1564.1496176732@sss.pgh.pa.us> >> It'd be interesting if people could gather similar numbers on other >> platforms of more real-world relevance, such as ppc64. But based on >> this small sample, I wouldn't object to just going to -fPIC across >> the board. > [ more numbers ] OK, this looks good to me. Just to make sure everyone's on the same page, what I propose to do is simplify all our platform-specific Makefiles that use either -fpic or -fPIC to use -fPIC unconditionally. This affects the netbsd, linux, and openbsd ports. Looks like we should also change the example link commands in dfunc.sgml. Next question: should we back-patch this change, or just do it in HEAD? regards, tom lane
Commits
-
Always use -fPIC, not -fpic, when building shared libraries with gcc.
- cee7238de58f 9.3.18 landed
- a378b9bc287d 9.2.22 landed
- 8d9b4fe01b5e 9.6.4 landed
- 894ce0e97ab1 9.4.13 landed
- 68938ab8ea0e 9.5.8 landed
- e9a3c047a5fc 10.0 landed